Custom port support in Terminal manager#1459
Merged
RohitKushvaha01 merged 2 commits intoAcode-Foundation:mainfrom Jul 27, 2025
RohitKushvaha01:terminal-custom-port
Merged
Custom port support in Terminal manager#1459RohitKushvaha01 merged 2 commits intoAcode-Foundation:mainfrom RohitKushvaha01:terminal-custom-port
RohitKushvaha01 merged 2 commits intoAcode-Foundation:mainfrom
RohitKushvaha01:terminal-custom-port
Conversation
Member
|
I can't tell if Rohit, Is Describing a PR, or giving critics. |
bajrangCoder
approved these changes
Jul 27, 2025
| scrollOnUserInput: true, | ||
| rows: options.rows || 24, | ||
| cols: options.cols || 80, | ||
| port: options.port || 8767, |
Member
There was a problem hiding this comment.
I'm not sure but this might create injection vulnerabilities ig. Also it should be passed as number or whatever is expected type of it.
Member
Author
There was a problem hiding this comment.
The purpose is to let plugin developers start terminal sessions that connect to their own AXS instances. So yes, it's technically an injection vulnerability but intended
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terminal is useless for plugins if we cannot connect to custom axs ports